Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with the open shortcut test in e2e tests. The main changes address test flakiness by adding proper wait conditions for file upload inputs and updating test data to reflect current URL structures.
- Added explicit wait for upload input visibility before interacting with it
- Updated shortcut test URL to match current site structure
- Disabled console error failures for mobile webkit tests
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/e2e/support/objects/app-files/resource/actions.ts | Added wait condition for upload input visibility to prevent race conditions |
| tests/e2e/cucumber/features/navigation/shortcut.feature | Updated expected external URL for shortcut test |
| package.json | Added flag to disable console error failures for mobile webkit tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ScharfViktor
force-pushed
the
fix/open-shortcut
branch
from
dbbb16f to
a914f7c
Compare
Member
|
Thanks 🙏 |
AlexAndBear
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test expected the opening of https://opencloud.eu/news, but on our website the link was changed to https://opencloud.eu/en/blog-news.