fix: endless propfind requests when opening public links authenticated#1534
Merged
fix: endless propfind requests when opening public links authenticated#1534
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the application bootstrap process by parallelizing independent API calls and adds cancellation support to resource context operations using vue-concurrency.
- Parallelize loading of role definitions, spaces, and configuration during bootstrap
- Convert
getResourceContextto a cancellable task using vue-concurrency - Thread abort signals through resource loading operations for better cancellation support
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/web-runtime/src/index.ts | Parallelizes three independent async operations (role definitions, spaces, configuration) and adds import for UnifiedRoleDefinition type |
| packages/web-pkg/src/composables/resources/useGetResourceContext.ts | Converts async function to vue-concurrency task with abort signal support for cancellable resource context loading |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JammingBen
force-pushed
the
fix/endless-propfind-requests
branch
4 times, most recently
from
626e775 to
5b0c7fe
Compare
This issue was introduced by the authenticated config loading because it delayed the space loading. This change makes sure both things happen in parallel. Additionally, changes the `getResourceContext` method to a task so it gets cancelled on unmount, reducing the likelihood of such an endless loop even more.
JammingBen
force-pushed
the
fix/endless-propfind-requests
branch
from
5b0c7fe to
62ae861
Compare
kulmann
approved these changes
Nov 10, 2025
openclouders
pushed a commit
that referenced
this pull request
Nov 10, 2025
fix: endless propfind requests when opening public links authenticated
Member
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue was introduced by the authenticated config loading because it delayed the space loading. This change makes sure both things happen in parallel. I only needed to extract
spacesInitializedso it can be set outside ofloadSpaces.Additionally, changes the
getResourceContextmethod to a task so it gets cancelled on unmount, reducing the likelihood of such an endless loop even more.fixes #1512