feat: share links and passwords in embed mode#1613
Merged
JammingBen merged 2 commits intoopencloud-eu:mainfrom Nov 14, 2025
Merged
feat: share links and passwords in embed mode#1613JammingBen merged 2 commits intoopencloud-eu:mainfrom
JammingBen merged 2 commits intoopencloud-eu:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the embed mode functionality by allowing the parent application to receive both share links and passwords when creating links, rather than only copying them to the clipboard. The change enables better integration scenarios, such as inserting links with passwords directly into chat messages or emails.
- Modified the "Copy link and password" button behavior in embed mode to emit structured data to the parent application
- Introduced a new event
owncloud-embed:share-linksthat includes both URLs and optional passwords - Maintained backward compatibility by keeping the deprecated
opencloud-embed:shareevent
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dschmidt
force-pushed
the
feat/share-links-and-passswords
branch
from
8b800d6 to
5538d1f
Compare
JammingBen
reviewed
Nov 14, 2025
dschmidt
commented
Nov 14, 2025
Co-authored-by: Jannik Stehle <[email protected]>
openclouders
pushed a commit
that referenced
this pull request
Nov 14, 2025
feat: share links and passwords in embed mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change the "copy link and password" action in CreateLinkModal in embed mode to actually pass link(s) and password(s) to the parent application.
Related Issue
This is not the expected outcome, but I think it's the better solution. The ticket suggest to remove the button, I think it's better to pass the password with the url to the parent application. That way the parent application can insert the password with the link into a chat message or an email.
Yes, second channel would be better - but let's be honest, being forced to use a password in the default configuration is annoying enough for most users (me included).
How Has This Been Tested?
postMessage<Array<{ url: string; password?: string }>>withconsole.logand open OpenCloud with?embed=trueTypes of changes