Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds a photo roll navigation panel to the preview app, allowing users to see thumbnails of all previewable files and navigate between them.
Key Changes:
- Modified the
CachedFiletype to makeurlan optional Vue ref for reactive preview URL updates - Created a new
PhotoRoll.vuecomponent that displays a vertical thumbnail list with auto-scrolling to active items - Updated the
App.vueto integrate the photo roll, simplify preloading logic, and handle photo roll selection
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/web-app-preview/src/helpers/types.ts | Changed url property from string to optional Vue ref for reactive preview URLs |
| packages/web-app-preview/src/components/PhotoRoll.vue | Added new photo roll component with thumbnail display and navigation |
| packages/web-app-preview/src/App.vue | Integrated photo roll component, updated URL handling to use refs, and simplified preloading logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Woah, this is awesome guys! Really love it! 😍 Some tiny UX "issues":
|
kulmann
reviewed
Dec 8, 2025
openclouders
pushed a commit
that referenced
this pull request
Dec 8, 2025
feat: add photo roll to preview app
|
Please make it optional via env-var as it produces heavy load on Server-CPUs. Opencloud runs for months with loads up to 1.5 until now. But the use of the Photo-roll by a single user crashes the system and makes opencloud unusable for me on that computer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How Has This Been Tested?
Types of changes