Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes inconsistent horizontal margins in filter chip components by adjusting padding and gap values to achieve balanced spacing on both sides of the chip.
Key Changes:
- Updated filter chip button styling to use
px-3instead ofpx-2for base padding - Changed gap handling to use dynamic
gap-sizeprop with conditional logic based on filter state - Added CSS transition for smooth gap changes
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/design-system/src/components/OcFilterChip/OcFilterChip.vue | Modified button padding from px-2 to px-3, changed gap from static gap-1 to dynamic gap-size prop, and added px-0 for active state |
| packages/web-pkg/tests/unit/components/snapshots/ItemFilter.spec.ts.snap | Updated snapshot to reflect new CSS classes: gap-0, px-3, and transition-[gap] |
| packages/web-pkg/tests/unit/components/Filters/snapshots/DateFilter.spec.ts.snap | Updated snapshot to reflect new CSS classes: gap-0, px-3, and transition-[gap] |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/design-system/src/components/OcFilterChip/OcFilterChip.vue
Outdated
Show resolved
Hide resolved
JammingBen
force-pushed
the
fix/design-system-filter-margins
branch
from
085a96a to
1061da1
Compare
JammingBen
force-pushed
the
fix/design-system-filter-margins
branch
from
1061da1 to
9691bd7
Compare
kulmann
approved these changes
Dec 15, 2025
openclouders
pushed a commit
that referenced
this pull request
Dec 15, 2025
…argins fix(design-system): filter chip margins
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before (note the increased margin on the left side compared to the right):
After: