fix(calendar): use type="a" for external documentation link#1801
fix(calendar): use type="a" for external documentation link#1801JammingBen merged 2 commits intoopencloud-eu:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where an external documentation link in the Calendar page was incorrectly using type="router-link" instead of type="a". The fix ensures the link properly opens in a new tab. Additionally, documentation examples are added to clarify the correct usage of the type prop for different link scenarios.
Key Changes:
- Fixed external link type from
router-linktoawithtarget="_blank" - Added documentation section with examples for both external links and internal navigation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/web-runtime/src/pages/account/accountCalendar.vue | Fixed button type from router-link to a for external documentation link and added target="_blank" to open in new tab |
| packages/design-system/docs/components/OcButton/OcButton.md | Added "Links" section with examples demonstrating correct usage of type="a" for external links and type="router-link" for internal navigation |
The changes are well-implemented and follow the existing codebase patterns. The bug fix is straightforward and correct - using type="router-link" for an external URL would not function properly since Vue Router is designed for internal navigation. The documentation additions provide clear guidance to prevent similar issues in the future.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@michaelstingl I think you have to rebase your PR to get CI green. |
type="router-link" with external href causes Vue Router error. External links should use type="a". Fixes opencloud-eu#1800
michaelstingl
force-pushed
the
fix/calendar-external-link
branch
from
a4847cb to
c95a181
Compare
|
Rebased, thanks for the review! |
fix(calendar): use type="a" for external documentation link
Description
Fix external documentation link in Calendar page that was using
type="router-link"instead oftype="a".Also adds documentation examples for the
typeprop to clarify usage.Related Issue
How Has This Been Tested?
/account/calendarwith Radicale disabled, verify "here" link rendersTypes of changes