Merged
Conversation
kulmann
commented
Jan 13, 2026
| mimeType: resource.props[DavProperty.MimeType], | ||
| name, | ||
| extension: isFolder ? '' : extension, | ||
| extension, |
Member
Author
There was a problem hiding this comment.
we also need the extension for folders so that we can register editor apps on folder extensions (since all folders have the same mimetype).
kulmann
commented
Jan 13, 2026
|
|
||
| const menuItemsContext = computed(() => { | ||
| return [...unref(navigateActions), ...unref(defaultEditorActions)] | ||
| return unref(openWithDefaultActions) |
Member
Author
There was a problem hiding this comment.
navigate is no longer treated as a system action, but is part of the possible default actions on a file (not so much) or folder (yep).
kulmann
commented
Jan 13, 2026
| export * from './useFileActionsCopy' | ||
| export * from './useFileActionsCopyPermanentLink' | ||
| export * from './useFileActionsDisableSync' | ||
| export * from './useFileActionsCreateLink' |
Member
Author
There was a problem hiding this comment.
re-ordered the exports lexicographically so that it's harder for you to spot the new one 😇
kulmann
force-pushed
the
folder-editor-apps
branch
from
1280343 to
bc7eb36
Compare
JammingBen
force-pushed
the
folder-editor-apps
branch
from
242aa90 to
3b48960
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR brings a set of changes to be able to register editor apps on folders.
Required for opencloud-eu/web-extensions#327
I decided to clean up the signature of
useFileActions, because it was rather confusing. This is breaking.Types of changes