fix: context menu for shares on search result page#1835
Merged
Conversation
Fixes the broken context menu for incoming shares on the search result page. The issue was an invalid resource dom selector. We can just use the default one from the resource table component.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a broken context menu for incoming shares on the search result page by removing an invalid custom resource DOM selector and using the default selector from the resource table component instead.
Changes:
- Removed custom
resourceDomSelectorfunction that was causing context menu issues - Removed unused
extractDomSelectorimport from@opencloud-eu/web-client - Removed
resource-dom-selectorprop from the resource table component
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kulmann
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the broken context menu for incoming shares on the search result page.
The issue was an invalid resource dom selector. We can just use the default one from the resource table component.
fixes #1833