Skip to content

fix: break long resource names in right sidebar#1836

Merged
JammingBen merged 3 commits intomainfrom
fix/sidebar-name-line-break
Jan 19, 2026
Merged

fix: break long resource names in right sidebar#1836
JammingBen merged 3 commits intomainfrom
fix/sidebar-name-line-break

Conversation

@JammingBen
Copy link
Member

@JammingBen JammingBen commented Jan 16, 2026

fixes #1696

Also refactors SpaceInfo and ResourceName to script setup (see individual commits).

@JammingBen JammingBen self-assigned this Jan 16, 2026
Copilot AI review requested due to automatic review settings January 16, 2026 13:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an issue where long resource names were not breaking properly in the right sidebar by adding CSS classes to enable text wrapping. Additionally, it refactors two components from the Options API to the Composition API with script setup.

Changes:

  • Added break-all CSS class to resource names in SpaceInfo and FileInfo components to allow long names to wrap
  • Refactored SpaceInfo.vue from Options API to script setup
  • Refactored ResourceName.vue from Options API to script setup with TypeScript props

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
packages/web-pkg/src/components/SideBar/Spaces/SpaceInfo.vue Refactored to script setup and added break-all class to space name heading
packages/web-pkg/src/components/SideBar/Files/FileInfo.vue Added break-all class to ResourceName component via Tailwind arbitrary variant
packages/web-pkg/src/components/FilesList/ResourceName.vue Refactored from Options API to script setup with TypeScript defineProps
packages/web-pkg/tests/unit/components/sidebar/Spaces/snapshots/SpaceInfo.spec.ts.snap Updated snapshot to reflect template and CSS changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JammingBen JammingBen requested a review from kulmann January 16, 2026 13:59
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: the second commit has a typo in the commit message 🙈 (refactpr: instead of refactor:).
Thanks for the fix and the script setup goodness!

@JammingBen JammingBen force-pushed the fix/sidebar-name-line-break branch from c26805e to 915b127 Compare January 19, 2026 14:16
@JammingBen JammingBen merged commit 10106c1 into main Jan 19, 2026
28 checks passed
@JammingBen JammingBen deleted the fix/sidebar-name-line-break branch January 19, 2026 14:33
@openclouders openclouders mentioned this pull request Jan 19, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Sidbar button/text are cut off

3 participants