fix: delete action showing without any selected file in trash bin#1853
Merged
fix: delete action showing without any selected file in trash bin#1853
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression where the delete action was incorrectly showing when no files were selected in the trash bin. The fix adds early return guards to check if any resources are selected before evaluating visibility conditions.
Changes:
- Added resource length validation in
isVisiblemethods to prevent delete actions from appearing when no files are selected
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/web-pkg/src/composables/actions/files/useFileActionsDelete.ts
Outdated
Show resolved
Hide resolved
JammingBen
force-pushed
the
fix/duplicated-delete-action-in-trashbin
branch
from
35a1ccd to
13076d8
Compare
kulmann
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression from #1832