e2e-tests. Check avatar tests in shares view#792
Merged
ScharfViktor merged 2 commits intomainfrom Jun 5, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends the end-to-end tests for validating user avatars across various views and API interactions. Key changes include:
- Adding new functions and locators for handling avatar images in notifications and resource tables.
- Updating collaborator and cucumber step definitions to support both avatar images and initials.
- Incorporating API support for uploading profile images.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e/support/objects/runtime/application.ts | Added function to retrieve sharer avatar from notifications. |
| tests/e2e/support/objects/app-files/share/collaborator.ts | Updated collaborator check to verify avatar image or initials depending on the 'hasAvatar' flag. |
| tests/e2e/support/objects/app-files/resource/index.ts & actions.ts | Introduced and exported new locator functions for avatars on resource rows. |
| tests/e2e/support/api/graph/userManagement.ts & index.ts | Added API support for uploading user profile images. |
| tests/e2e/cucumber/steps/ui/* | Updated cucumber step definitions and feature files to verify avatar visibility in various contexts. |
| packages/web-pkg/src/components/FilesList/ResourceTable.vue | Changed property name from userName to displayName to reflect updated data model. |
Comments suppressed due to low confidence (2)
tests/e2e/support/objects/app-files/share/collaborator.ts:87
- [nitpick] The variable name 'collaboratorIndication' is ambiguous; consider renaming it to 'collaboratorAvatarIndicator' to clearly reflect its purpose.
private static readonly collaboratorIndication =
tests/e2e/cucumber/features/user-settings/profilePhoto.feature:29
- [nitpick] Consider updating the phrase 'has uploads' to 'has uploaded' for grammatical correctness.
Given "Alice" has uploads the profile image "testavatar.jpeg" using API
ScharfViktor
force-pushed
the
userProfilePhotoTests
branch
from
0696ea3 to
d6372bb
Compare
Member
|
As a followup we could also check the avatars in the activities panel |
Contributor
Author
Right! for this place I forgot to add test. I'll do it in this PR |
AlexAndBear
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related #767
addition to #742
I check user's avatar in: