fix: Added advanced Shift-Click-Handling for Files#824
Merged
Conversation
kulmann
previously requested changes
Jun 30, 2025
Member
kulmann
left a comment
kulmann
left a comment
There was a problem hiding this comment.
I found small things that are not accurate, yet:
- tiles view: when nothing is selected, yet, a click on whitespace of a tile should select the item. no selection happens.
- tiles view: if something is already selected, with shift+click on a preview, the link gets opened in a new window (expected), but the selection doesn't happen (which it should, in addition to the new windows)
- tiles view: if something is already selected, with shift+click on a file or folder name, the selection happens but the new browser window doesn't open?!
packages/web-app-files/src/components/FilesList/QuickActions.vue
Outdated
Show resolved
Hide resolved
AlexAndBear
reviewed
Jun 30, 2025
kulmann
reviewed
Jul 2, 2025
Member
kulmann
left a comment
kulmann
left a comment
There was a problem hiding this comment.
Still some things off:
- tiles view: shift+click on preview opens the file in a new window but doesn't select the file (shift+click on filename works like that now, great!)
- cmd/ctrl+click triggers buttons while shift+click doesn't. We should be consistent, so the cmd/ctrl+click should also NOT trigger buttons. this is for tiles and list view.
packages/web-pkg/src/composables/actions/files/useFileActionsCopyPermanentLink.ts
Outdated
Show resolved
Hide resolved
JammingBen
reviewed
Jul 18, 2025
Member
JammingBen
left a comment
JammingBen
left a comment
There was a problem hiding this comment.
Works nicely! 🥳 Just a few things code-wise from my side.
packages/web-pkg/src/composables/keyboardActions/useInterceptModifierClick.ts
Outdated
Show resolved
Hide resolved
packages/web-pkg/src/composables/actions/files/useFileActionsCopyPermanentLink.ts
Outdated
Show resolved
Hide resolved
packages/web-pkg/src/composables/actions/files/useFileActionsShowShares.ts
Outdated
Show resolved
Hide resolved
JammingBen
reviewed
Aug 5, 2025
packages/web-pkg/src/composables/actions/files/useFileActionsCopyPermanentLink.ts
Outdated
Show resolved
Hide resolved
packages/web-pkg/src/composables/actions/files/useFileActionsCopyPermanentLink.ts
Outdated
Show resolved
Hide resolved
packages/web-pkg/src/composables/actions/files/useFileActionsShowShares.ts
Outdated
Show resolved
Hide resolved
JammingBen
reviewed
Aug 7, 2025
Member
JammingBen
left a comment
JammingBen
left a comment
There was a problem hiding this comment.
A few final nitpick from my side.
packages/web-pkg/src/composables/actions/files/useFileActionsShowShares.ts
Outdated
Show resolved
Hide resolved
2 tasks
openclouders
pushed a commit
that referenced
this pull request
Aug 15, 2025
* fix: Added advanced Shift-Click-Handling for Files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added advanced Shift-Click-Handling for Files
Related Issue #625