feat: Templated names and tags for Consul targets#610
Merged
karimra merged 3 commits intoopenconfig:mainfrom Mar 13, 2025
Merged
feat: Templated names and tags for Consul targets#610karimra merged 3 commits intoopenconfig:mainfrom
karimra merged 3 commits intoopenconfig:mainfrom
Conversation
Collaborator
|
Why not use the existing fields under loader:
type: consul
address: consul:8500
datacenter: "dc99"
services:
- name: gnmic-sros
config:
name: "{{.Meta.device}}"
event-tags:
region: "{{.Meta.region}}"
geo: "{{.Meta.geo}}"
test: "{{.Meta.test}}" |
Contributor
Author
|
@karimra - updated to use the config section to work with that example config. It's is much cleaner |
karimra
approved these changes
Mar 13, 2025
Collaborator
|
Thanks for the contribution! And sorry for the delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to use Go Templates on Consul targets to set both the name of the target as well as event-tags. The primary driving force for this comes from Telegraf's Prometheus Input Plugin which also has Consul support and allows for using Go templates to set the name/tags as well.
As an example, you are now able to do something like:
This also removes a debugging statement in
pkg/config/loader.gothat could potentially expose passwords in log messages