Fix sync_response output for ONCE mode subscriptions#690
Merged
karimra merged 2 commits intoopenconfig:mainfrom Aug 18, 2025
Merged
Fix sync_response output for ONCE mode subscriptions#690karimra merged 2 commits intoopenconfig:mainfrom
karimra merged 2 commits intoopenconfig:mainfrom
Conversation
Contributor
Author
|
Example output: $ ./gnmic -a r1:9339 -u user -p pass! --insecure subscribe -e proto --format prototext --mode once --stream-mode sample --path /system/state/hostname
update: {
timestamp: 1753007645075333719
update: {
path: {
elem: {
name: "system"
}
elem: {
name: "state"
}
elem: {
name: "hostname"
}
}
val: {
string_val: "r1"
}
}
}
sync_response: true |
Contributor
Author
|
@karimra bump for review/comment |
karimra
approved these changes
Aug 18, 2025
Collaborator
|
Thanks for the contribution and sorry for the delay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/openconfig/reference/blob/master/rpc/gnmi/gnmi-specification.md#35151-once-subscriptions
Current behavior was suppressing
sync_responseoutput forONCEmodesubscriptions due to lack of switch/case fallthrough.
Collapsed switch/case to provide same behavior on logging as
STREAM