feat: support env vars from loaders#726
Merged
karimra merged 5 commits intoopenconfig:mainfrom Sep 14, 2025
Merged
Conversation
Collaborator
|
It would be good if this feature stays behind a knob |
karimra
approved these changes
Sep 14, 2025
Collaborator
karimra
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By this change, I can collect multiple devices with different creds on the same instance
I will create all the secrets as env like
Now SD can load targets and instruct with creds to use
OR Let me know if this has to be enabled based on a config vars under loader
i can do something like this as well