Skip to content

feat: support env vars from loaders#726

Merged
karimra merged 5 commits intoopenconfig:mainfrom
senthilsam:feat/loader_expand_env
Sep 14, 2025
Merged

feat: support env vars from loaders#726
karimra merged 5 commits intoopenconfig:mainfrom
senthilsam:feat/loader_expand_env

Conversation

@senthilsam
Copy link
Contributor

@senthilsam senthilsam commented Sep 11, 2025

By this change, I can collect multiple devices with different creds on the same instance
I will create all the secrets as env like

ven1_user='user1'
ven1_pass='test1'
ven2_user='user2'
ven2_pass='test2'

Now SD can load targets and instruct with creds to use


target1:
    name: target1.domain.net
    address: target1.domain.net:9339
    username: ${ven1_user}
    password: ${ven1_pass}
    subscriptions:
        - ven-sample

OR Let me know if this has to be enabled based on a config vars under loader

i can do something like this as well

var targetsDefaultsFunc func(tc *types.TargetConfig) error
if expandEnv, ok := a.Config.Loader["expandEnv"].(bool); ok && expandEnv {
targetsDefaultsFunc = a.Config.SetTargetConfigDefaultsExpandEnv
} else {
targetsDefaultsFunc = a.Config.SetTargetConfigDefaults
}
ld := loaders.Loaders[ldTypeS]()
	err := ld.Init(ctx, a.Config.Loader, a.Logger,
		loaders.WithRegistry(a.reg),
		loaders.WithActions(a.Config.Actions),
		loaders.WithTargetsDefaults(targetsDefaultsFunc),
	)

@karimra
Copy link
Collaborator

karimra commented Sep 13, 2025

It would be good if this feature stays behind a knob expandEnv: true| false defaulting to false

Copy link
Collaborator

@karimra karimra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@karimra karimra merged commit e9aacd9 into openconfig:main Sep 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants