Fix consul loader tag matching logic to allow services with extra metadata tags#736
Merged
karimra merged 1 commit intoopenconfig:mainfrom Sep 18, 2025
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…adata tags The previous implementation incorrectly rejected services that had all required tags plus additional metadata tags (like vendor:arista, environment:production). This change fixes the tag matching logic to only reject services that are missing required tags, not services that have extra tags. This resolves silent filtering of valid services in multi-tenant environments. Fixes openconfig#706
drewelliott
force-pushed
the
fix/consul-loader-tag-matching-issue-706
branch
from
d9847ff to
ce21a7e
Compare
karimra
approved these changes
Sep 18, 2025
Collaborator
|
Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the consul loader tag matching logic that was incorrectly rejecting services with extra metadata tags.
Problem: The previous implementation rejected services that had all required tags plus additional metadata tags (like
vendor:arista,environment:production). This caused silent filtering of valid services in multi-tenant environments.Solution: Changed the tag matching logic to only reject services that are missing required tags, not services that have extra tags. This implements proper subset matching behavior.
Test Plan: Added comprehensive tests that verify the fix works correctly and demonstrate what the old buggy logic would do vs the new correct logic.
Fixes #706