Add gas estimation to the postTransaction RPC#279
Conversation
This reverts commit 0345af0.
|
Should be good to go for ETH transactions, albeit dodgy code, let me know what you think. |
|
For future reference, if anyone is reading this PR: |
|
Let me know what you think about that, I could use final-form-calculate, it works as expected for ETH and tokens, but I can't get rid of a warning message: |
amaury1093
left a comment
There was a problem hiding this comment.
It's cleaner imo, but estimateGas() shouldn't be called in validateAmount() anymore.
|
Thanks a lot, I addressed the comments and it should look better now. No more error, token transfer also have gas in |
postTransaction RPC
amaury1093
left a comment
There was a problem hiding this comment.
nice! Only some grumbles left
|
Thanks again, comments addressed :) |
amaury1093
left a comment
There was a problem hiding this comment.
Sorry, found 2 more small grumbles
|
No problem, I think it makes a lot of sense and simplifies things quite a bit. I've tested, as always, and it looks like it works :) |
|
👍 |
parity_postTransactionRPC to prevent any error from the node. The node knows nothing about the transaction and does not estimate gas (too costly) so it defaults to an amount of gas that is much greater than 21000.