Skip to content
This repository was archived by the owner on May 24, 2022. It is now read-only.

misc: Fixes #282. Add minimum version of Node.js. Add .nvmrc file#287

Merged
Stefie merged 3 commits intomasterfrom
luke-282-node-version
Dec 13, 2018
Merged

misc: Fixes #282. Add minimum version of Node.js. Add .nvmrc file#287
Stefie merged 3 commits intomasterfrom
luke-282-node-version

Conversation

@ltfschoen
Copy link
Contributor

No description provided.

@Stefie
Copy link
Contributor

Stefie commented Dec 13, 2018

To specify a node version greater or equal just use

"engines": {
    "node": ">=v8.12.0",
    ....
},

@Stefie
Copy link
Contributor

Stefie commented Dec 13, 2018

Locally I'm still getting an error with version "node": "^8.12.0".

^ is for minor versions, so anything higher than 8.12, but not 9.x or 10.x.

On the test server we're running 8.14.0, that's why the pipeline goes through. I'm on node 10.13, that's why the build is failing for me. If you're using >= instead of ^ you're including major versions as well.

@Stefie Stefie merged commit 4fd83b2 into master Dec 13, 2018
@Tbaut Tbaut deleted the luke-282-node-version branch December 14, 2018 10:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants