This repository was archived by the owner on May 24, 2022. It is now read-only.
fix: Fixes #251. Show validation error when value to send decimal places exceeds max decimal places of token#290
Merged
amaury1093 merged 5 commits intomasterfrom Dec 14, 2018
Conversation
…alidation if input more than token dps
amaury1093
approved these changes
Dec 14, 2018
Collaborator
|
Tested, works well! Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user enters 0.9 Wei (i.e. 0.0000000000000000009) on the "Send Ether" page, then we show the following validation error (since we know the name of its smallest unit):
Whereas if they are trying to send any other token, for example on the "Send THIBCoin" page, we check the token's decimal places (which corresponds to the minimum token value) and show the validation error if the user enters a value that has more decimal places than the token's (max) decimal places as shown below:
