Add Max button to send the whole balance#302
Conversation
Tbaut
changed the title
|
Happy to get some more ideas about the look&feel.
|
|
TODO: |
amaury1093
left a comment
amaury1093
left a comment
There was a problem hiding this comment.
Works well, some code needs change.
At first the amount not being in the middle also felt a bit weird. Idea: put the max button smaller, cf #38? So that amount still seems in the middle.
|
I couldn't find a satisfying position at the bottom right, so I centred it as well and find it better: When it's not active Once the user has clicked the max, the amount is then disabled. |
|
Another suggestion: I tried without the border so that it feels a little lighter, but then it doesn't look like a button anymore. |
amaury1093
left a comment
amaury1093
left a comment
There was a problem hiding this comment.
I like the small button design
|
|
||
| if (token.address === 'ETH') { | ||
| output = fromWei( | ||
| toWei(balance).minus(gasBn.mul(toWei(gasPriceBn, 'shannon'))) |
There was a problem hiding this comment.
I would prefer to merge #274 first, because the syntax is changed to .multipliedBy
|
on ice until we merge #274 |
|
Will rebase #274 on top of this. |
2 participants
closes #254
TODO:
1. Understand why the max button actually submits the form2. Understand this
3. Style the button. More on this later (using this would be great but I couldn't manage to make it work so far)
4. Test with ERC20
I need help regarding 1. and 2. @axelchalon, @amaurymartiny or @yjkimjunior whoever has time :)Looks like this:
it acts as a toggle button, the gas and address can be changed and the amount will update accordingly, if max is selected, the amount field is disabled.