feat: Relates to #311. Switch to Blockscout. Update tx link#314
feat: Relates to #311. Switch to Blockscout. Update tx link#314amaury1093 merged 13 commits intomasterfrom
Conversation
…e TokenBalance component * Opens link to the Etherscan account page when the user clicks the TokenBalance component on the "Send Ether" page * Opens link to directly to the specific token page of the Etherscan account when the user clicks the TokenBalance component on the "Send THIBCoin" (or other non-Ether token) page
…kscout file to utils
Tbaut
left a comment
Tbaut
left a comment
There was a problem hiding this comment.
To fix #311 we just need to change Etherscan for Blockscout. This icon adds noise to the screen and I don't believe it fits well here.
Reminder: Fether is very much appreciated for its simplicity and slick design. Let's keep things as simple and minimalist as possible. Anything added to the screen should be thought 7x about.
ltfschoen
changed the title
|
Ok, I thought this would be convenient for users based on this feedback from @amaurymartiny #310 (comment). |
Tbaut
left a comment
Tbaut
left a comment
There was a problem hiding this comment.
Small nits, otherwise works well 👍 thanks!
As usual, I'd wait for those who know better for a proper code review 😎
|
@Tbaut I've pushed further commits addressing your latest comments |
|
👍 lgtm functionnality-wise |
amaury1093
left a comment
amaury1093
left a comment
There was a problem hiding this comment.
Works well! Tiny comments
| // SPDX-License-Identifier: BSD-3-Clause | ||
|
|
||
| const baseUrl = chainName => { | ||
| let baseUrl; |
There was a problem hiding this comment.
Can you pick a different variable name?
baseUrl is also the name of the function, when you do baseUrl = ... the reader is not 100% sure... It seems to work though.
|
@ltfschoen Can you address the above nit (should take 5min), so that we can merge this one? |
|
@amaurymartiny yes making the changes |
3 participants
Screenshots below:
Token list page
Send Ether page
Send THIBCoin page
