Simple but nice, either it's my screen or the black of the icon is more black than other icon (such as the +)?
Can we make sure to add a tooltip with something along the side "Give feedback on Github" so that users don't have to click to know what's going on?

Nice! As per #158, we're trying to move to Semantic UI. Could you maybe use one of the icons from https://react.semantic-ui.com/elements/icon/, if they are nice enough?

@amaurymartiny I've used Semantic UI icons before somewhere. I just tried replacing the existing icons with them as follows but I can't get anything to appear so far:

import { Icon } from 'semantic-ui-react';

<Icon link name='question circle outline'/>

Also tried the Semantic-UI tooltip https://semantic-ui.com/modules/popup.html suggested by @Tbaut and wrapping the contents of the Feedback component as follows, but can't get the tooltip to display above the account cards (tried changing z-index and so forth unsuccessfully so far)

<div className='feedback-icon ui icon' data-tooltip='Give feedback on Github'>

What about something even more obvious (and what I am used to see elsewhere) as I fear a simple icon is not completely clear:

Wait for some feedback (:confused: / :+1: ?) before implementing it.

@Tbaut Great idea, much better than an icon that may have people guessing as to what it means

@Tbaut I've pushed a commit with the changes.

Screenshot:

@amaurymartiny I've pushed commits that address your latest review comments

I just tested on mac, and it shows a padding below the feedback button. @ltfschoen Can you try on yours? Apart from this nit I'm ready to merge the PR.

@amaurymartiny that's strange, it doesn't have the padding on mine (see screenshot below), so i'll have to look into that.

if i go into Developer Tools and add margin-bottom: 10px; (see screenshot below) then it looks similar to what you're seeing, but it shows shadow below my feedback button whereas there isn't any below mine.

i'm using Electron Version 2.0.3 (2.0.3) and Chrome 71.0.3578.80 (Official Build) (64-bit)

@amaurymartiny i have to add margin-bottom: 10px for it to add that bottom padding that you're seeing, except you don't have any bottom shadow for some reason.

i'm using the latest Chrome Version 71.0.3578.98 (Official Build) (64-bit) and Electron Version 2.0.3 (2.0.3)

After some quick testing, I think it only happens when you have only 1 account (and related to the min-height property on .window).

It doesn't bother me that much actually, so I'll just let @Tbaut have a last look if he's okay with this, if yes, we can merge.

Note: what actually bothers me a little bit more is the cursor: default on hover. Any reason why not to keep the default <a> behavior?

@amaurymartiny Sorry, I misinterpreted the following previous comment. I'll change back to default behaviour

just to remove the cursor:pointer

@amaurymartiny Yes you're correct, I temporarily changed it to just show one account in AccountList.js (i.e. {new Array(accountsList[0]).map(address => () and it shows the feedback button offset from the bottom. I'll see if I can fix that now

That'd be great to fix this little offset to keep the screen consistent.

@amaurymartiny @Tbaut I've pushed some commits that fixes the offset that occurs when the account list length is undefined, 0 or 1

The hack works, I'm good with how it looks if @amaurymartiny is fine with the hack :)