This repository was archived by the owner on May 24, 2022. It is now read-only.
Fix #280: form field focus on input on component mount#323
Merged
amaury1093 merged 14 commits intomasterfrom Jan 3, 2019
Merged
Fix #280: form field focus on input on component mount#323amaury1093 merged 14 commits intomasterfrom
amaury1093 merged 14 commits intomasterfrom
Conversation
pmespresso
changed the title
pmespresso
changed the title
Collaborator
|
There's a prop called |
amaury1093
reviewed
Jan 2, 2019
Collaborator
amaury1093
left a comment
amaury1093
left a comment
There was a problem hiding this comment.
See my PR #328, I think there's an easier way to achieve this.
Merge into yj-focus-formfield - Don't use keycodes
amaury1093
suggested changes
Jan 2, 2019
packages/fether-react/src/Accounts/CreateAccount/AccountName/AccountName.js
Outdated
Show resolved
Hide resolved
Tbaut
approved these changes
Jan 3, 2019
Collaborator
Tbaut
left a comment
Tbaut
left a comment
There was a problem hiding this comment.
That works well!
Tested on JSON import and export.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#280
fether-uito be a class component to focus on input on componentDidMount()