This repository was archived by the owner on May 24, 2022. It is now read-only.
Switch order from "to" and "amount" fields on Signer screen#339
Merged
amaury1093 merged 3 commits intomasterfrom Jan 7, 2019
Merged
Switch order from "to" and "amount" fields on Signer screen#339amaury1093 merged 3 commits intomasterfrom
amaury1093 merged 3 commits intomasterfrom
Conversation
ltfschoen
approved these changes
Jan 7, 2019
Contributor
There was a problem hiding this comment.
lgtm.
nitpick. I noticed that the 'To' field on the Signer screen has an extra space of approx. 0.25rem between its input field value and its label, which differs from the 'Amount` field, and differs from the gap in the same area of the 'To' field on the TxForm screen.
If you click 'Send' then 'Cancel, and repeat those steps whilst looking at the gap shown in the screenshot below you'll see it jump slightly
Collaborator
Author
|
Nice catch, I actually tried to verify this, but didn't see it at first because the screen was flashing. Should be solved by my last commit. |
amaury1093
approved these changes
Jan 7, 2019
Collaborator
amaury1093
left a comment
amaury1093
left a comment
There was a problem hiding this comment.
lgtm, re-running CI to make it green
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #338