Skip to content
This repository was archived by the owner on May 24, 2022. It is now read-only.

Bump version to 0.2.0#346

Merged
Tbaut merged 2 commits intomasterfrom
tbaut-bump-version-020
Jan 8, 2019
Merged

Bump version to 0.2.0#346
Tbaut merged 2 commits intomasterfrom
tbaut-bump-version-020

Conversation

@Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Jan 8, 2019

My linter removed empty lines at the end of files. Let me know if that's a problem.

@amaury1093
Copy link
Collaborator

Hey Thibaut, I'm pretty sure I told you the contrary before (I was mistaken), but the version in lerna.json actually also needs to match up 0.2.0

@amaury1093
Copy link
Collaborator

Just to make sure:

  • when this is merged, we do not create a new branch
  • when we decide to release 0.2, we clone the head of master into a new branch beta
  • right after, we bump master to 0.3.
  • all subsequent code that goes into beta goes via backports.
  • and from that point we just follow parity-ethereum's dev pattern

Copy link
Collaborator

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Tbaut
Copy link
Collaborator Author

Tbaut commented Jan 8, 2019

Ack, I bumped lerna.json I'll prepare the PR to bump to 0.3.

@amaury1093
Copy link
Collaborator

Hmm, I maybe wasn't clear. What I meant is that we keep 0.2.0 until we release beta. Only after the release do we do 0.3.0.

@Tbaut Tbaut merged commit cb4a547 into master Jan 8, 2019
@Tbaut Tbaut deleted the tbaut-bump-version-020 branch January 8, 2019 15:34
@Tbaut
Copy link
Collaborator Author

Tbaut commented Jan 8, 2019

Ok that's also fine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants