This repository was archived by the owner on May 24, 2022. It is now read-only.
fix: Relates to #324. Show link to Blockscout upon confirmed, not the first confirmation#377
Merged
amaury1093 merged 2 commits intomasterfrom Jan 21, 2019
Merged
fix: Relates to #324. Show link to Blockscout upon confirmed, not the first confirmation#377amaury1093 merged 2 commits intomasterfrom
amaury1093 merged 2 commits intomasterfrom
Conversation
…t confirmation
Tbaut
approved these changes
Jan 21, 2019
Collaborator
Tbaut
left a comment
There was a problem hiding this comment.
Sure, that's makes the UX better without changing much to the code. I don't mind the padding as well 👍
amaury1093
approved these changes
Jan 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To overcome situations when we don't receive any sendStore.confirmations for a long time after it txStatus.confirmed key is set (i.e. situations when sendStore.confirmations jumps from a value of say -1 to a high value which corresponds to a long delay waiting without the user knowing what's going on), we'll make sure we provide a link to the Blockscout transaction as soon as txStatus.confirmed key is set, because at the moment it only shows the link after
confirmations >= 0, but the value ofconfirmationsmay stay at a negative number for a long time.Now what happens is:
Previously it still didn't show a link to Blockscout, because it would still be waiting for
confirmations >= 0even though the transaction would be available on Blockscout.In this PR we now show the Blockscout link to the transaction as soon it txStatus is confirmed.
In this PR I've added extra padding between the title and the link to Blockscout