This repository was archived by the owner on May 24, 2022. It is now read-only.
fix: Fix txStatus race condition in sendStore#381
Merged
amaury1093 merged 3 commits intomasterfrom Jan 23, 2019
Merged
Conversation
Might fix #379 Previously, we would resolve the promise and then set `this.txStatus`. However, resolving the promise actually redirects to `Sent` which expects `txStatus` to already be defined
for good measure
axelchalon
changed the title
ltfschoen
approved these changes
Jan 22, 2019
Contributor
ltfschoen
left a comment
ltfschoen
left a comment
There was a problem hiding this comment.
LGTM
I just tried sending a transaction from a Parity Signer account and now when I click "View > Reload" from the menu when it displays "Sending Transaction..." in the UI, which appears after scanning all the QR codes and pressing "Send", it no longer displays the error and successfully takes me back to the Account List page.
I also just tried sending a transaction from a non-Parity Signer account and now when I click "View > Reload" from the menu when it displays "Sending Transaction..." in the UI, which appears after pressing "Confirm", it no longer displays the error and successfully takes me back to the Account List page.
amaury1093
approved these changes
Jan 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Might fix #379
Previously, we would resolve the promise and then set
this.txStatus. However, resolving the promise actually redirects toSentwhich expectstxStatusto already be defined