This repository was archived by the owner on May 24, 2022. It is now read-only.
Conversation
ltfschoen
changed the title
amaury1093
approved these changes
Jan 23, 2019
Collaborator
amaury1093
left a comment
amaury1093
left a comment
There was a problem hiding this comment.
Yes, lgtm. I think you did this in the previous PR, I accidentally told you to remove this part (I didn't grasp the issue), sorry about that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the menu is open and you click away from the menu (blur) to close it, then previously if your blur click was on a button then it would recognise the blur as being a click on a button that just so happened to be where you randomly clicked.
Now when you blur click there is an underlay that absorbs the blur click and disappears again until the menu is opened again.
Previously this functionality was introduced in PR #356 (comment), however it was accidently removed when addressing review comments.