Conversation
There was a problem hiding this comment.
-
I've been able to replicate the issue by running
rm -rf ~/Library/Application\ Support/fether/ && rm -rf ~/Library/Application\ Support/Electron/.
Where is that information stored in Linux and Windows so I can test it there too? -
It works great if it doesn't run the "if statement" when
isFirstRunistrue. But if I comment out the codeif (isFirstRun) {so it runs the code in that if statement (i.e. pretending that it's the first time I've run it), and then open Developer Tools and open it in Full Screen so I can choose the Application tab and clear Local Storage, then when I runyarn electronwhen it opens the Terms of Use page the "Accept" button doesn't work when I click it (not even after Parity Ethereum has downloaded).
Also, why is it storingparitylight::firstRunwith a value offalseeven though I've deleted everything in those directories and cleared local storage? Shouldn't it be recognising that it's my first run? (sorry haven't had time to investigate this myself yet) -
Additionally, when I was testing, somehow I managed to get to the Accounts page, and when it showed
Downloading Parity Ethereum... (100%)using the component (instead of the overlay) at 100% it caused that message to shift over to a new line (instead of on the same line as the small health icon (since100has one more character than99).
See appData here https://github.com/electron/electron/blob/master/docs/api/app.md#appgetpathname
This is an expected behavior when you remove the line
hmm, that's weird. Normally, if you run Side note: a better name for
The best way to achieve that is to do
Fixed, thanks. |
3 participants
To test:
rm -rf ~/Library{Application Support/{io.parity.ethereum | Electron | fether}On master, #416 introduced a bug where, on fresh launch, a blank screen was shown (because of these lines).
This PR basically just replaces this
nullwith aRequireHealthOverlay.Moreover,
<Health>and<HealthModal>(both can be rendered before api is defined) use light.js'schainName$when syncing/synced, but we only allow calling this method when the api is connected.