Skip to content
This repository was archived by the owner on May 24, 2022. It is now read-only.

fix: Relates to #429. Fether menu toggles on Windows and Linux Mint with ALT#433

Closed
ltfschoen wants to merge 3 commits intomasterfrom
luke-429-fether-menu-visibility
Closed

fix: Relates to #429. Fether menu toggles on Windows and Linux Mint with ALT#433
ltfschoen wants to merge 3 commits intomasterfrom
luke-429-fether-menu-visibility

Conversation

@ltfschoen
Copy link
Contributor

I've pushed a commit that makes the Fether window have a "frame" on Linux, and enables auto-hide so the user can toggle the menu to show/hide by pressing the ALT key.

Note that I think we need a usage guide (see related comment here #400 (comment)) where we highlight that pressing ALT toggles the menu on Linux and Windows, whereas doing so is not necessary on macOS. Particularly since the tray balloon popup that appears and points out to the user that they can toggle the Fether menu by pressing ALT is an Electron feature that is only supported on Windows.

Bug: Toggling the menu by pressing ALT does not appear to correctly modify the window height in
fether-electron/src/main/app/messages/index.js so the bottom of the window's contents isn't cropped when the menu is shown

@Tbaut
Copy link
Collaborator

Tbaut commented Feb 20, 2019

This goes back to an earlier comment: do we really need this AlwaysOnTop parameter? Are we willing to sell the frame-less-ability for it? My opinion is that it looks better without a frame and I think, it feels also more like a taskbar app. Fether use-case today doesn't justify the need to have it always on top.

I am for keeping the frame-less window, have the window hide on blur (like literally any taskbar app I've used) and we call it a day :)

Oh and to allow users on windows and linux to close the app, we should have a menu item on the taskbar icon that says "quit" or "exit" on left-click (again that's the standard behaviour).

@ltfschoen
Copy link
Contributor Author

ltfschoen commented Feb 20, 2019

do we really need this AlwaysOnTop parameter?

No we don't. I've created a simple PR #435 that addresses #411 so that the Fether window is not always on top by default (i.e. the Fether window blurs when the user clicks anywhere else on the screen).

The other PR #415 is an optional extra that allows users to toggle enable/disable whether the Fether window is always on top or not. The user would obviously need to be able to access the Fether menu to be able to click the menu item.

Are we willing to sell the frame-less-ability for it?

The "frame" is required at the moment because otherwise the Fether menu does not appear at all on Windows and Linux Mint. PR #415 only adds an additional menu item, but there are other menu items that the user may need to use.
In the short-term thought it would be best to add the "frame" for Linux and Windows since otherwise they cannot access the menu.
In the long-term, I will investigate whether we can get the Fether menu to appear when the user right-clicks the Fether window, that was we can make it "frameless" again on Linux and Windows, like it is on macOS.

My opinion is that it looks better without a frame and I think, it feels also more like a taskbar app. Fether use-case today doesn't justify the need to have it always on top.

I agree, "frameless" is better. As mentioned earlier in the post, I've created PR #435 so it isn't always on top by default anymore.

@ltfschoen
Copy link
Contributor Author

I am for keeping the frame-less window, have the window hide on blur (like literally any taskbar app I've used) and we call it a day :)

I'm about to board a flight, will respond soon

Oh and to allow users on windows and linux to close the app, we should have a menu item on the taskbar icon that says "quit" or "exit" on left-click (again that's the standard behaviour).

I'm about to board a flight, will respond soon

@axelchalon
Copy link
Contributor

I agree that always on top isn't really needed, and I also think the best would be to have "Exit Fether" as a menu item in the tray icon contextual menu; that way we could also keep Fether frameless

@ltfschoen
Copy link
Contributor Author

I agree that always on top isn't really needed, and I also think the best would be to have "Exit Fether" as a menu item in the tray icon contextual menu; that way we could also keep Fether frameless

Yes, at the moment the 'Electron/Fether' menu tab is only shown on macOS, we can also show the 'Electron/Fether' menu tab on Linux/Windows but just with the 'quit' menu item

@Tbaut
Copy link
Collaborator

Tbaut commented Feb 21, 2019

We can close this one, I created a dedicated issue for the menu: #438

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants