fix: Relates to #429. Fether menu toggles on Windows and Linux Mint with ALT#433
fix: Relates to #429. Fether menu toggles on Windows and Linux Mint with ALT#433
Conversation
|
This goes back to an earlier comment: do we really need this I am for keeping the frame-less window, have the window hide on blur (like literally any taskbar app I've used) and we call it a day :) Oh and to allow users on windows and linux to close the app, we should have a menu item on the taskbar icon that says "quit" or "exit" on left-click (again that's the standard behaviour). |
No we don't. I've created a simple PR #435 that addresses #411 so that the Fether window is not always on top by default (i.e. the Fether window blurs when the user clicks anywhere else on the screen). The other PR #415 is an optional extra that allows users to toggle enable/disable whether the Fether window is always on top or not. The user would obviously need to be able to access the Fether menu to be able to click the menu item.
The "frame" is required at the moment because otherwise the Fether menu does not appear at all on Windows and Linux Mint. PR #415 only adds an additional menu item, but there are other menu items that the user may need to use.
I agree, "frameless" is better. As mentioned earlier in the post, I've created PR #435 so it isn't always on top by default anymore. |
I'm about to board a flight, will respond soon
I'm about to board a flight, will respond soon |
|
I agree that always on top isn't really needed, and I also think the best would be to have "Exit Fether" as a menu item in the tray icon contextual menu; that way we could also keep Fether frameless |
Yes, at the moment the 'Electron/Fether' menu tab is only shown on macOS, we can also show the 'Electron/Fether' menu tab on Linux/Windows but just with the 'quit' menu item |
|
We can close this one, I created a dedicated issue for the menu: #438 |
I've pushed a commit that makes the Fether window have a "frame" on Linux, and enables auto-hide so the user can toggle the menu to show/hide by pressing the ALT key.
Note that I think we need a usage guide (see related comment here #400 (comment)) where we highlight that pressing ALT toggles the menu on Linux and Windows, whereas doing so is not necessary on macOS. Particularly since the tray balloon popup that appears and points out to the user that they can toggle the Fether menu by pressing ALT is an Electron feature that is only supported on Windows.
Bug: Toggling the menu by pressing ALT does not appear to correctly modify the window height in
fether-electron/src/main/app/messages/index.js so the bottom of the window's contents isn't cropped when the menu is shown