Skip to content
This repository was archived by the owner on May 24, 2022. It is now read-only.

feat: Relates to #402. Internationalisation. German Language Support#464

Merged
Tbaut merged 28 commits intomasterfrom
luke-402-german
Apr 12, 2019
Merged

feat: Relates to #402. Internationalisation. German Language Support#464
Tbaut merged 28 commits intomasterfrom
luke-402-german

Conversation

@ltfschoen
Copy link
Contributor

@ltfschoen ltfschoen commented Mar 17, 2019 •
edited
Loading 

        "fetching_chain_id": "Fetching chain ID",
        "fetching_eth_balance": "Fetching Ether balance",
        "fetching_tx_count": "Fetching transaction count for nonce",
  • Add the following to packages/fether-react/src/i18n/locales/de.json with German translation:
  "releases": {
    "new_release_title": "New version available",
    "new_release_description": "{{release_name}} was released!"
  },

  • Remove from packages/fether-react/src/i18n/locales/de.json the whole health.token_list key/value section

  • Peer review of Fether menu by someone fluent in German (since I just used Google Translate). fether-electron/src/main/app/menu/i18n/locales/de.json. Review completed thanks to @Robbepop

  • Peer review of the Fether contents by someone fluent in German (since I just used Google Translate). fether-react/src/i18n/locales/de.json Propose the merge and create an issue requesting "proper" translation of this file by an open-source German native language speaker.

@ltfschoen
chore: Update to latest React 16.8.3 to requirements of react-i18next
e7a81dc
@ltfschoen
feat: Scaffold basic translation with English and German
27c6e06
@ltfschoen
feat: Relates to #402. German translation fully working
12142e2
@ltfschoen
fix: Switch back to English by default
fe1efc3
@ltfschoen
Merge branch 'master' into luke-402-i18n
33c66f3
@ltfschoen
fix: Allow user to switch between languages in preferences of context…
55b4270 
… menu
@ltfschoen
feat: Translate the context menus
9574abc
@ltfschoen
refactor: Remove German language. Add as separate PR
f3b6124
@ltfschoen
refactor: Remove blank line
060ac5f
@ltfschoen
feat: Add German language using Google Translate only
d53dbb9
@ltfschoen
fix: Fix Fether menu German language translation after review from @R…
03d2ec2 
…obbepop (native German speaker)
@ltfschoen
docs: Update Readme with Internationalisation Add New language instru…
013470b 
…ctions
@ltfschoen
docs: Update Readme with Known Issues and Usage instructions
674219c
@ltfschoen ltfschoen mentioned this pull request Mar 17, 2019
Merged
9 tasks
@Tbaut
Copy link
Collaborator

Tbaut commented Mar 19, 2019

I removed the "goodfirstissue" as this is a label for issues. We should create some proper issues for that.

@ltfschoen
Copy link
Contributor Author

ltfschoen commented Apr 11, 2019

@amaurymartiny @Tbaut i've merged latest from 'master' and from 'luke-402-i18n' branches and fixed merge conflicts, an

To switch between languages, just right-click in the Fether window to open the Fether context menu, choose Preferences > Language > English or German.
Then the Fether window will refresh and show it in the other language.

@ltfschoen
Copy link
Contributor Author

ltfschoen commented Apr 11, 2019

i've created a Fether FAQ PR https://github.com/paritytech/wiki/pull/327 that explains:

  • How to switch between languages that Fether supports?
  • How to add support for a new language to Fether?

amaury1093
amaury1093 approved these changes Apr 12, 2019
View reviewed changes
Copy link
Collaborator

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Tbaut
Tbaut approved these changes Apr 12, 2019
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Tbaut
Copy link
Collaborator

Tbaut commented Apr 12, 2019

Sorry I've mistakenly merged the luke-402-i18n to master before. Created #510 to merge this one to master now.

@amaury1093
Copy link
Collaborator

amaury1093 commented Apr 12, 2019

Or you could change the base of this one in the top-right Edit button on Github

@Tbaut Tbaut changed the base branch from luke-402-i18n to master April 12, 2019 11:07
@Tbaut
Copy link
Collaborator

Tbaut commented Apr 12, 2019

:) for some reason I thought only Luke could do that, thanks

@Tbaut Tbaut merged commit 21ca5d6 into master Apr 12, 2019
@Tbaut Tbaut deleted the luke-402-german branch April 12, 2019 11:08
@ltfschoen ltfschoen mentioned this pull request May 7, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@amaury1093 amaury1093 amaury1093 approved these changes

@Tbaut Tbaut Tbaut approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A8-looksgood

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ltfschoen @Tbaut @amaury1093