Conversation
|
Just wondering: instead of copy/pasting mycrypto's scripts here, could we use git submodules? https://git-scm.com/book/en/v2/Git-Tools-Submodules Seems to me like a more elegant method (because there's no copy/paste duplication), but maybe I did like this in my old commit because git modules were overly complicated (for me). |
|
You tell me as I'm far from a git wizard. edit: I added comments on the PR to mention where I modified things |
| [key: string]: T; | ||
| } | ||
|
|
||
| const networks = [ |
| const ipfsHtml = await httpsGet(ipfsTargetUrl); | ||
|
|
||
| // Get the IPFS url for the each network tokens json. Regexxing HTML hurts, but w/e | ||
| networks.forEach(async network => { |
There was a problem hiding this comment.
I've added this forEach loop to fetch the tokens for all our supported networks
|
After discussion, it looks like using submodules is overkill for this specific case as we'd have to clone the whole repo (there's no possibility to create a submodule out of a directory). |
|
My last commit makes the whole thing "usable" with hardcoded addresses or fetched from the To test you can run edit : updated first post where everything is explained. for the full storyThe code that fetches the addresses from the `ethereum-list` repo actually first retrieves an html page (1) with a list of links to the files (2) that we are interested in. Since IPFS is content addressed, the addresses of the files that I hardcoded should be the same as the files (2) contained on that html page (1). I generated the files from the `ethereum-list` repo and uploaded them to ipfs (see 1st post how). Now the reason why the script is still blocked even though I uploaded and pinned the seemingly same files is that the first IPFS end-point the html page (1) containing this list of files is unreachable! |
amaury1093
left a comment
amaury1093
left a comment
There was a problem hiding this comment.
This works well for me! 💯
Also, you can remove the fether-react/scripts folder
Tbaut
deleted the
tbaut-use-token-list-from-github.com/ethereum-lists/tokens
branch
| logo: tokenLogo; | ||
| } | ||
|
|
||
| export interface tokenLogo { |
There was a problem hiding this comment.
@Tbaut i'm in the process i've merging these changes into the luke-124-security branch, and this doesn't let me commit without fixing a pre-commit linting error paritytech/fether/scripts/updateTokens/types/TokensJson.ts:13:9: 'tokenLogo' was used before it was define
There was a problem hiding this comment.
oh weird that I haven't been noticed about that. I'd then simply advise to move the lines starting with export token interface tokenLogo toward the top of the file.
There was a problem hiding this comment.
I think it only showed the linting error because I didn't realise I was using an older version of Node.js.
3 participants
This PR is almost entirely copied from an old commit from @amaurymartiny that's taken from MyCrypto 🥇
closes Use an up to date token currated list #267
For now, and for when this happens, we need to manually build the token lists, for the record it needs:
-
git clone https://github.com/ethereum-lists/tokens-
cd tokens-
./gradlew run- upload and pin to IPFS the files in
./build/output/full/<ipfs_network_name>.json- change the hardcoded IPFS addresses in
/fether/scripts/updateTokens/update-tokens.ts- run
yarn update-tokens --use-hardcoded-ipfs-addressestested Fether by adding tokens that I know weren't present before, e.g
MKRorZRXtested successfully on Mainnet with DAI, DADI (non 0 balances).
To reproduce without touching real accounts simply paste the following in the console:
localStorage.setItem("localforage/__paritylight::paritySignerAccounts", '[{"address":"0x77d0C0A0B7a9bEfd0ebB3b9A9E445fA9eeFfB67A","name":"Random","chainId":1}]');, this will add the account as a Signer account, and you can see it has ETH, DAI and DADI tokens. Note that it's a random account found on the internet :)added a fallback image in case the token image is either not present or not reachable. It looks like this:
