This repository was archived by the owner on May 24, 2022. It is now read-only.
Conversation
Tbaut
approved these changes
Apr 8, 2019
Collaborator
There was a problem hiding this comment.
I've tested it on top of the security PR #451 the following way:
- Merged the security branch and this branch locally.
- I commented the
postinstallscript that checks and download parity infether-electron/package.jsonbecause Parity Ethereum v2,5 isn't released yet. - checkout
betafrom Parity Ethereum (v2.5)
- cherry-picked the commit responsible for the improvement (openethereum/parity-ethereum@10e1787) edit: not needed anymore
git cherry-pick 10e1787ad1aa589912991c90d65f356a097d98a7
- Built and launched Parity Ethereum 2.5
Worked well for normal and Signer accounts
amaury1093
force-pushed
the
am-bump-lightjs
branch
from
b94ca75 to
be438f5
Compare
Collaborator
Author
|
I just tried with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires parity-ethereum 2.5.0. Let's wait for it to be released, and test this.
Implements openethereum/js-libs#213