This repository was archived by the owner on May 24, 2022. It is now read-only.
fix: Fixes #494 Drag vs Context menu. Import options page error and colour#496
Merged
fix: Fixes #494 Drag vs Context menu. Import options page error and colour#496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when the user right-clicks the Fether window the 'contextmenu' is not always shown since it can't do this at the same time as when the drag window functionality is available i.e.
-webkit-app-region: drag;https://electronjs.org/docs/api/frameless-window#draggable-regionOn Linux here is an example of the new functionality on a few of the pages:
account list page
account page
send ether / token page
contextmenuevent (show Fether context menu) on elements that also use-webkit-app-region: drag(drag to move Fether window around the screen)Note that the import account recover from seed phrase section of code was refactored because as a result of the changes the "next button" was overlayed by the footer.
Note that whilst I understand that notifications will be undertaken in a separate PR, currently the notifications when importing an account are not always obvious (since there's not enough space at the moment for the notifications, just a scrollbar appears when a notification occurs that requires them to scroll down to see it, but the user may not realise why the scrollbar appeared). So I've made a few tweaks just to make the notifications more obvious in the interim until we refactor the import account pages and add notifications.