This repository was archived by the owner on May 24, 2022. It is now read-only.
feat: Add timeout on confirmation screens#540
Merged
amaury1093 merged 7 commits intomasterfrom Aug 30, 2019
Merged
Conversation
Tbaut
approved these changes
Aug 30, 2019
Collaborator
Tbaut
left a comment
Tbaut
left a comment
There was a problem hiding this comment.
Works perfectly with Signer and a local account.
Password field is reset.
Checked the code as well.
💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #537
Repro:
Expected: should go back to TxForm screen.
Note: Added on password unlock and Parity signer confirm screens.