Skip to content
This repository was archived by the owner on May 24, 2022. It is now read-only.

Use IPC instead of WebSockets#559

Merged
amaury1093 merged 10 commits intomasterfrom
ac-ipc
Oct 8, 2019
Merged

Use IPC instead of WebSockets#559
amaury1093 merged 10 commits intomasterfrom
ac-ipc

Conversation

@axelchalon
Copy link
Contributor

@axelchalon axelchalon commented Oct 1, 2019 •
edited
Loading

Close #546

Todo:

  • Test sending a transaction
  • Test on Windows

(cc @Tbaut when you have time!)

@axelchalon axelchalon requested review from Tbaut and amaury1093 October 1, 2019 15:22
amaury1093
amaury1093 reviewed Oct 2, 2019
View reviewed changes
Copy link
Collaborator

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well! I'm syncing ropsten now, will put a green check if I can send a tx from normal and signer (on macOS).

@Tbaut
Copy link
Collaborator

Tbaut commented Oct 7, 2019 •
edited
Loading

  • I launched a node with parity --light --chain kovan --ws-port 8546 --ipc-path /home/user/jsonrpc.ipc
  • launched parity with yarn electron --ipc-path /home/user/jsonrpc.ipc
  • Sync went fine, I could see the balance of my accounts but I couldn't send a Tx, when entering my password something goes wrong, not sure why because I'm in production and don't have the console :|

@axelchalon
Copy link
Contributor Author

axelchalon commented Oct 7, 2019

You have to launch the node with the additional flag --ipc-apis=all (this enables the personal api used to manually sign a transaction)

Tbaut
Tbaut approved these changes Oct 8, 2019
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well thank you so much!

Tested:

  • add new account with JSON
  • add new token (on top of ETH)
  • send ETH from normal account
  • send Token from Signer account

@Tbaut Tbaut requested a review from amaury1093 October 8, 2019 02:09
amaury1093
amaury1093 approved these changes Oct 8, 2019
View reviewed changes
Copy link
Collaborator

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had another look at the code, lgtm!

Still didn't manage to send a tx on kovan, ropsten, goerli..., but if Thibaut tested it, then let's merge!

@amaury1093 amaury1093 merged commit f8ccea1 into master Oct 8, 2019
@amaury1093 amaury1093 deleted the ac-ipc branch October 8, 2019 09:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@amaury1093 amaury1093 amaury1093 approved these changes

@Tbaut Tbaut Tbaut approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use IPC instead of Websockets

3 participants

@axelchalon @Tbaut @amaury1093