Fix #215: Copy gaff dat file to temp dir#219
Merged
jchodera merged 3 commits intoopenmm:masterfrom Aug 4, 2022
Merged
Conversation
Copy the gaff dat file to the temporary directory before running parmchk2 to avoid problems with spaces in the path.
jchodera
requested changes
Aug 2, 2022
Member
jchodera
left a comment
jchodera
left a comment
There was a problem hiding this comment.
@rosemary-cresset : Thanks so much for this, and apologies for taking so long to get to reviewing this! We'll be working on getting a new release out the door quickly!
When copying the gaff dat file to the temporary directory to avoid spaces in the path, also use a fixed file name, 'gaff.dat', in case of spaces in the file name too.
Member
|
@mikemhenry : This should be merged if the ubuntu tests pass. |
Member
|
@mikemhenry : Tests finally passed, so I've merged this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy the gaff dat file to the temporary directory before running
parmchk2 to avoid problems with spaces in the path.