Closed
Conversation
Collaborator
|
@mattwthompson @ijpulidos I closed a bunch of PRs that I think #290 took care of, is this one still needed? |
mattwthompson
commented
Jul 19, 2023
Comment on lines
+1046
to
+1048
| raise Exception(f"Two instances of force {force_name} appear in System") | ||
| if force_name not in supported_forces: | ||
| raise Exception(f"Custom forces not supported. Found force of type {force_name}.") |
Collaborator
Author
There was a problem hiding this comment.
I should probably add I don't think this is the right exception to raise, I'm just not sure which it should be
Collaborator
There was a problem hiding this comment.
Eh, this package doesn't define many exceptions, but I made a new one
Collaborator
|
Not sure why this PR isn't running, @mattwthompson can you remake it when you have the chance? |
Collaborator
Author
|
I'm pretty sure #247 is unaddressed, it's not directly related to the other PRs we've had opened. I'm not sure why I opened this on my fork, moving it to upstream now |
Merged
Collaborator
|
Ah and yes it was a fork thing and not a permissions thing, oops |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a short-term band-aid for #247 - implementing them will take more than a trivial amount of time so we should at least error out instead of silently ignoring entire forces in user's systems.