Merged
Conversation
Collaborator
|
I will merge this in once I get the other PRs merged in, run the pre-commit on the whole code base, squash in the commits, then add a file so the web-ui knows to skip that commit in the blame |
Collaborator
|
just updated the oe license and re-started CI |
Collaborator
Author
|
Merging upstream changing in now ... |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #319 +/- ##
==========================================
+ Coverage 52.80% 52.98% +0.18%
==========================================
Files 5 5
Lines 820 804 -16
==========================================
- Hits 433 426 -7
+ Misses 387 378 -9 ☔ View full report in Codecov by Sentry. |
mikemhenry
approved these changes
May 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I find it difficult to read some changesets in this project, owing largely to things like long lines and inconsistent text wrapping. Enter (standard set of tools). The https://pre-commit.ci/ would make this a little smoother but is not necessary.
The changes here are mostly automated, though I had to make some manual fixes and I've also nested a few questions inside the code itself.
Happy to take responsibility for rebasing other PRs.