Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
==========================================
- Coverage 53.04% 52.98% -0.06%
==========================================
Files 5 5
Lines 805 804 -1
==========================================
- Hits 427 426 -1
Misses 378 378 ☔ View full report in Codecov by Sentry. |
Collaborator
|
I ran into some frustration with the docstrings being long in line length (which isn't inherently a horrible thing IMO) and flake8 or ruff not being happy |
mikemhenry
commented
May 3, 2024
| @@ -1,3 +1,4 @@ | |||
| # ruff: noqa: E501 | |||
Collaborator
Author
There was a problem hiding this comment.
@mattwthompson yes I don't think it a bad thing, so I just had it skip this whole file and this was the only file where they were too long
Collaborator
There was a problem hiding this comment.
Seems good, the config is still pretty simple
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.