Skip to content

Using stdlib importlib.resources instead of importlib_resources#403

Merged
mattwthompson merged 1 commit intomainfrom
use-stdlib-importlib
Aug 21, 2025
Merged

Using stdlib importlib.resources instead of importlib_resources#403
mattwthompson merged 1 commit intomainfrom
use-stdlib-importlib

Conversation

@ijpulidos
Copy link
Collaborator

@ijpulidos ijpulidos commented Aug 21, 2025 •
edited
Loading

Just a minor nice to have. We could do the same without relying on the third party importlib_resources, and instead using the stdlib importlib.resources package.

@ijpulidos
Copy link
Collaborator Author

ijpulidos commented Aug 21, 2025

To be precise, this is related to the issue conda-forge/openmmforcefields-feedstock#25 in the feedstock.

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.14%. Comparing base (a9a41bb) to head (4b74da6).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #403   +/-   ##
=======================================
  Coverage   84.14%   84.14%           
=======================================
  Files           5        5           
  Lines         776      776           
=======================================
  Hits          653      653           
  Misses        123      123

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ijpulidos ijpulidos requested a review from mikemhenry August 21, 2025 06:31
@mattwthompson mattwthompson merged commit 44b7d67 into main Aug 21, 2025
14 checks passed
@mattwthompson mattwthompson deleted the use-stdlib-importlib branch August 21, 2025 12:12
@apayne97
Copy link

apayne97 commented Aug 23, 2025 •
edited
Loading

@ijpulidos I think this broke tests in drugforge, but I'm not sure how exactly? Through OpenFE somehow?
https://github.com/choderalab/drugforge/actions/runs/17165256011/job/48704084488?pr=2

Nope, this is you fixing it. I see the issue here now: conda-forge/openmmforcefields-feedstock#25

@mikemhenry mikemhenry mentioned this pull request Dec 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattwthompson mattwthompson mattwthompson approved these changes

@mikemhenry mikemhenry Awaiting requested review from mikemhenry

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ijpulidos @codecov-commenter @apayne97 @mattwthompson