OCPBUGS-29804: Fix crash if helm chart metadata is nil#13963
OCPBUGS-29804: Fix crash if helm chart metadata is nil#13963openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
Conversation
|
@jerolimov: An error was encountered searching for bug OCPBUGS-29804 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details. Full error message.
You do not have the permission to see the specified issue.: request failed. Please analyze the request body for more details. Status code: 401:
Please contact an administrator to resolve this issue, then request a bug refresh with DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@jerolimov: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci-robot
added
jira/valid-reference
|
@jerolimov: This pull request references Jira Issue OCPBUGS-29804, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
component/backend
| if entries[i] == nil || entries[i].Metadata == nil { | ||
| klog.Warningf("Helm chart %v from repository %v has an invalid entry at index %v", key, helmRepo.Name, i) | ||
| entries = append(entries[:i], entries[i+1:]...) | ||
| continue | ||
| } |
There was a problem hiding this comment.
This is actually the 5 new lines.
The rest is only because I renamed the array entry to entries.
There was a problem hiding this comment.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerolimov, Kartikey-star The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jerolimov: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@jerolimov: Jira Issue OCPBUGS-29804: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-29804 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jerolimov: #13963 failed to apply on top of branch "release-4.16": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
Fixes:
Fixes an internal crash related to https://issues.redhat.com/browse/OCPBUGS-29804 without updating the helm library.
Related to #13816
I added just one new nil check:
The rest of the change is only because I renamed the array
entrytoentries.Test setup:
https://jerolimov.github.io/helm-cve-2024-26147-test/Previously the page showed an error.
With this change the page works fine also with this broken helm repository.