Skip to content

[release-4.9] Bug 2008619: Add imagestream for driver-toolkit#64

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.9from
openshift-cherrypick-robot:cherry-pick-60-to-release-4.9
Oct 5, 2021
Merged

[release-4.9] Bug 2008619: Add imagestream for driver-toolkit#64
openshift-merge-robot merged 1 commit intoopenshift:release-4.9from
openshift-cherrypick-robot:cherry-pick-60-to-release-4.9

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Sep 30, 2021

This is an automated cherry-pick of #60

/assign dagrayvid

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 30, 2021
Merged
@openshift-ci openshift-ci bot requested review from dagrayvid and jmencak September 30, 2021 19:11
@dagrayvid
Copy link
Contributor

dagrayvid commented Sep 30, 2021

/retitle [release-4.9] Bug 2008619: Add imagestream for driver-toolkit

@openshift-ci openshift-ci bot changed the title [release-4.9] Add imagestream for driver-toolkit [release-4.9] Bug 2008619: Add imagestream for driver-toolkit Sep 30, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 30, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 30, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2008619, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.9] Bug 2008619: Add imagestream for driver-toolkit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dagrayvid
Copy link
Contributor

dagrayvid commented Sep 30, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 30, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 30, 2021

@dagrayvid: This pull request references Bugzilla bug 2008619, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2008290 is in the state VERIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 2008290 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
  • bug has dependents

Requesting review from QA contact:
/cc @wabouhamad

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from wabouhamad September 30, 2021 20:12
@dagrayvid
Copy link
Contributor

dagrayvid commented Sep 30, 2021

/cc @kpouget

@openshift-ci openshift-ci bot requested a review from kpouget September 30, 2021 21:14
wabouhamad
wabouhamad reviewed Oct 1, 2021
View reviewed changes
Copy link

@wabouhamad wabouhamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2021
@kpouget
Copy link
Contributor

kpouget commented Oct 1, 2021

thanks @dagrayvid @wabouhamad
/lgtm

/cc @mrunalp

@openshift-ci openshift-ci bot requested a review from mrunalp October 1, 2021 06:36
@dagrayvid
Copy link
Contributor

dagrayvid commented Oct 1, 2021

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dagrayvid, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2021
@kpouget
Copy link
Contributor

kpouget commented Oct 4, 2021

@mrunalp ping for a staff-eng-approved label
this PR is mandatory for our work on the entitlement-free GPU Operator reword, based on the DriverToolkit image

@mrunalp mrunalp added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Oct 5, 2021
@openshift-merge-robot openshift-merge-robot merged commit 25c3513 into openshift:release-4.9 Oct 5, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 5, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2008619 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.9] Bug 2008619: Add imagestream for driver-toolkit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kpouget
Copy link
Contributor

kpouget commented Oct 14, 2021

/cherry-pick release-4.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 14, 2021
Merged
@openshift-cherrypick-robot
Copy link
Author

openshift-cherrypick-robot commented Oct 14, 2021

@kpouget: new pull request created: #65

Details

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dagrayvid dagrayvid Awaiting requested review from dagrayvid

@jmencak jmencak Awaiting requested review from jmencak

@kpouget kpouget Awaiting requested review from kpouget

@mrunalp mrunalp Awaiting requested review from mrunalp

1 more reviewer

@wabouhamad wabouhamad wabouhamad left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kpouget kpouget

@wabouhamad wabouhamad

@dagrayvid dagrayvid

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@openshift-cherrypick-robot @dagrayvid @kpouget @wabouhamad @mrunalp @openshift-merge-robot