Skip to content

[release-4.8] Bug 2011460: Add imagestream for driver-toolkit#65

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.8from
openshift-cherrypick-robot:cherry-pick-64-to-release-4.8
Oct 15, 2021
Merged

[release-4.8] Bug 2011460: Add imagestream for driver-toolkit#65
openshift-merge-robot merged 1 commit intoopenshift:release-4.8from
openshift-cherrypick-robot:cherry-pick-64-to-release-4.8

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Oct 14, 2021

This is an automated cherry-pick of #64

/assign kpouget

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 14, 2021
Merged
@openshift-ci
Copy link

openshift-ci bot commented Oct 14, 2021

@openshift-cherrypick-robot: Detected clone of Bugzilla bug 2008619 with correct target release. Retitling PR to link to clone:
/retitle [release-4.8] [release-4.9] Bug 2011460: Add imagestream for driver-toolkit

Details

In response to this:

[release-4.8] [release-4.9] Bug 2008619: Add imagestream for driver-toolkit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.8] [release-4.9] Bug 2008619: Add imagestream for driver-toolkit [release-4.8] [release-4.9] Bug 2011460: Add imagestream for driver-toolkit Oct 14, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 14, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 14, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2011460, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2008619 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2008619 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

Requesting review from QA contact:
/cc @wabouhamad

Details

In response to this:

[release-4.8] [release-4.9] Bug 2011460: Add imagestream for driver-toolkit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kpouget
Copy link
Contributor

kpouget commented Oct 14, 2021

/hold openshift/kubernetes#1005 needs to be merged first
/title [release-4.8] Bug 2011460: Add imagestream for driver-toolkit #65

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2021
@kpouget
Copy link
Contributor

kpouget commented Oct 14, 2021

/retitle [release-4.8] Bug 2011460: Add imagestream for driver-toolkit

@openshift-ci openshift-ci bot changed the title [release-4.8] [release-4.9] Bug 2011460: Add imagestream for driver-toolkit [release-4.8] Bug 2011460: Add imagestream for driver-toolkit Oct 14, 2021
@kpouget
Copy link
Contributor

kpouget commented Oct 14, 2021 •
edited
Loading

Backport risk assessment

  • If the Bugzilla associated with the PR has the "FastFix" keyword, the subjective assessment on the issue has already been done and a customer is impacted. These PRs should be prioritized for merge.
    • not applicable
  • For branches that are in the Maintenance lifecycle phase:
    • not applicable
  • The bug has significant impact either through severity, reduction in supportability, or number of users affected.
    • bugzilla/severity-high
  • The severity field of the bug must be set to accurately reflect criticality.
    • bugzilla/severity-high
  • The PR is merged in the next newer release branch and the bug for that newer release is VERIFIED by QE.
    • ensured by bugzilla/valid-bug tag
  • The PR’s description is well formed with user-focused release notes that state the bug number, impact, cause, and resolution. Where appropriate, it should also contain information about how a user can identify whether a particular cluster is affected.

@kpouget
Copy link
Contributor

kpouget commented Oct 14, 2021

/retest

wabouhamad
wabouhamad reviewed Oct 14, 2021
View reviewed changes
Copy link

@wabouhamad wabouhamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2021
@dagrayvid
Copy link
Contributor

dagrayvid commented Oct 14, 2021

/retest

@openshift-ci openshift-ci bot mentioned this pull request Oct 15, 2021
Merged
@dagrayvid
Copy link
Contributor

dagrayvid commented Oct 15, 2021

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2021
@dagrayvid
Copy link
Contributor

dagrayvid commented Oct 15, 2021

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dagrayvid, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2021
@sdodson sdodson added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Oct 15, 2021
@openshift-merge-robot openshift-merge-robot merged commit 58bf9f0 into openshift:release-4.8 Oct 15, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 15, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2011460 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.8] Bug 2011460: Add imagestream for driver-toolkit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

@Deepthidharwar Deepthidharwar Awaiting requested review from Deepthidharwar

1 more reviewer

@wabouhamad wabouhamad wabouhamad left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kpouget kpouget

@wabouhamad wabouhamad

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@openshift-cherrypick-robot @kpouget @dagrayvid @wabouhamad @sdodson @openshift-merge-robot