LoRa: Add package lora-packet-forwarder#8320
Conversation
481b377 to
dbf8381
Compare
Signed-off-by: Xue Liu <[email protected]>
dbf8381 to
76326f4
Compare
|
@xueliu I found this I'm adding it to my PicoGW packages, I think it would make sense if you add it too... or perhaps we could create an independent package that wraps it up for both of us? Something line That way it would make it easier to not repeat ourselves and reuse that package for our respective installations? |
|
Looking through your PR, I think I might just drop my PR and stick with yours (good job with the UCI integration and all)... not sure if the SPI vs USB support is easily patchable. If that's the case, it'll be the best thing to do (instead of keeping 4 different packages, be done with just 2, your |
|
I went ahead and compared both codebases and they differ a bit on the start/init sequence, so it might not be worth the effort to patch/PR both codebases together on a second thought: lgw_start() on PicoGW (HAL): lgw_start() on lora_gateway (HAL): So forget what I mentioned on the previous comment about having just 2 "merged" packages instead of 4. |
We can make a package to hold json files in https://github.com/TheThingsNetwork/gateway-conf. But the problem is how to dynamic switch different json files. |
That's exactly right, I think that your approach with the https://github.com/xueliu/lora-feed is the way to go. |
Should be lora-packet-forwarder: Add |
|
@xueliu Hi do you mind I rebase this & adopt the commit message? |
|
Work continues here #13379 |
Signed-off-by: Xue Liu [email protected]
Maintainer: Xue Liu [email protected]
Compile tested: (RPi 2B LEDE snapshots 01.03.2019)
Run tested: (RPi 2B + im880a LEDE snapshots 01.03.2019)
Description:
This PR adds new packages for:
https://github.com/Lora-net/packet_forwarder
with my personal patches.
It dependes on #6808