Skip to content

LoRa: Add package lora-packet-forwarder#8320

Closed
xueliu wants to merge 1 commit intoopenwrt:masterfrom
xueliu:feature/lora-packet-forwarder
Closed

LoRa: Add package lora-packet-forwarder#8320
xueliu wants to merge 1 commit intoopenwrt:masterfrom
xueliu:feature/lora-packet-forwarder

Conversation

@xueliu
Copy link
Contributor

@xueliu xueliu commented Mar 1, 2019

Signed-off-by: Xue Liu [email protected]

Maintainer: Xue Liu [email protected]
Compile tested: (RPi 2B LEDE snapshots 01.03.2019)
Run tested: (RPi 2B + im880a LEDE snapshots 01.03.2019)

Description:

This PR adds new packages for:

https://github.com/Lora-net/packet_forwarder

with my personal patches.

It dependes on #6808

@xueliu xueliu changed the title LoRa: Add package packet-forwarder LoRa: Add package lora-packet-forwarder Mar 1, 2019
@xueliu xueliu force-pushed the feature/lora-packet-forwarder branch from 481b377 to dbf8381 Compare March 1, 2019 13:49
@xueliu xueliu force-pushed the feature/lora-packet-forwarder branch from dbf8381 to 76326f4 Compare March 1, 2019 14:28
@brainstorm
Copy link

brainstorm commented Mar 3, 2019

@xueliu I found this global_conf.json script and autogenerated gateway configs from TTN that will help us a lot in packaging this: https://github.com/TheThingsNetwork/gateway-conf

I'm adding it to my PicoGW packages, I think it would make sense if you add it too... or perhaps we could create an independent package that wraps it up for both of us? Something line lora-ttn-gateway-configs and put it as a dependency for our packet forwarder packages?

That way it would make it easier to not repeat ourselves and reuse that package for our respective installations?

@brainstorm
Copy link

brainstorm commented Mar 3, 2019

Looking through your PR, I think I might just drop my PR and stick with yours (good job with the UCI integration and all)... not sure if the SPI vs USB support is easily patchable. If that's the case, it'll be the best thing to do (instead of keeping 4 different packages, be done with just 2, your lora-gateway-hal and lora-packet-forwarder, the best thing to do w.r.t UX and avoiding duplication).

@brainstorm
Copy link

brainstorm commented Mar 3, 2019

I went ahead and compared both codebases and they differ a bit on the start/init sequence, so it might not be worth the effort to patch/PR both codebases together on a second thought:

lgw_start() on PicoGW (HAL):
https://github.com/Lora-net/picoGW_hal/blob/master/libloragw/src/loragw_hal.c#L825

lgw_start() on lora_gateway (HAL):
https://github.com/Lora-net/lora_gateway/blob/a955619271b5d0a46d32e08150acfbc1eed183b7/libloragw/src/loragw_hal.c#L696

So forget what I mentioned on the previous comment about having just 2 "merged" packages instead of 4.

@xueliu
Copy link
Contributor Author

xueliu commented Mar 8, 2019

@xueliu I found this global_conf.json script and autogenerated gateway configs from TTN that will help us a lot in packaging this: https://github.com/TheThingsNetwork/gateway-conf

I'm adding it to my PicoGW packages, I think it would make sense if you add it too... or perhaps we could create an independent package that wraps it up for both of us? Something line lora-ttn-gateway-configs and put it as a dependency for our packet forwarder packages?

That way it would make it easier to not repeat ourselves and reuse that package for our respective installations?

We can make a package to hold json files in https://github.com/TheThingsNetwork/gateway-conf. But the problem is how to dynamic switch different json files.

@brainstorm
Copy link

We can make a package to hold json files in https://github.com/TheThingsNetwork/gateway-conf. But the problem is how to dynamic switch different json files.

That's exactly right, I think that your approach with the https://github.com/xueliu/lora-feed is the way to go.

@neheb
Copy link
Contributor

neheb commented Aug 30, 2019

Commit subject line MUST start with '<package name>: ' ( LoRa: Add package packet-forwarder)

Should be lora-packet-forwarder: Add

@aparcar
Copy link
Member

aparcar commented Sep 9, 2020

@xueliu Hi do you mind I rebase this & adopt the commit message?

@aparcar
Copy link
Member

aparcar commented Sep 13, 2020

Work continues here #13379

@aparcar aparcar closed this Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants