Merged
Conversation
everettraven
approved these changes
Oct 14, 2022
Contributor
everettraven
left a comment
everettraven
left a comment
There was a problem hiding this comment.
All of these changes look good to me.
Contributor
|
So I think the sanity check in the test action is failing because of the testdata not matching up. I think doing a |
Member
That's exactly hat it was, but Ish' |
Pull Request Test Coverage Report for Build 3253021032
💛 - Coveralls |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to Bump K8s version to 1.25 and golang to 1.19
Additionally bumped versions for the linter and underlying support packages to be compatible with the latest golang.