Skip to content

Updates github.com/operator-framework/api#2954

Merged
openshift-merge-robot merged 2 commits intooperator-framework:masterfrom
m1kola:update-api
Apr 26, 2023
Merged

Updates github.com/operator-framework/api#2954
openshift-merge-robot merged 2 commits intooperator-framework:masterfrom
m1kola:update-api

Conversation

@m1kola
Copy link
Member

@m1kola m1kola commented Apr 13, 2023 •
edited
Loading

Description of the change:

Updates OLM to use a new release of github.com/operator-framework/api which includes several changes which are prerequisites for the following changes:

Motivation for the change:

Solving prerequisites for other changes.

Architectural changes:

Updating dependencies

Testing remarks:

Refactoring. Existing tests should provide coverage.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 13, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 13, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@m1kola m1kola mentioned this pull request Apr 13, 2023
Merged
11 tasks
@m1kola m1kola force-pushed the update-api branch 3 times, most recently from 1d04848 to 106751d Compare April 14, 2023 13:40
@m1kola m1kola closed this Apr 14, 2023
@m1kola m1kola reopened this Apr 14, 2023
@m1kola m1kola force-pushed the update-api branch 2 times, most recently from e85b3cd to 0ce77b3 Compare April 25, 2023 09:32
@m1kola m1kola mentioned this pull request Apr 25, 2023
Merged
@m1kola
Copy link
Member Author

m1kola commented Apr 25, 2023 •
edited
Loading

CI is red because packageserver fails with the following error (not visible in CI logs):

unable to get openapi models: cannot find model definition for github.com/operator-framework/api/pkg/operators/v1alpha1.APIResourceReference. If you added a new type, you may need to add +k8s:openapi-gen=true to the package or type and run code-gen again

Trying to fix it here: operator-framework/api#168

UPD: fixed.

@m1kola m1kola force-pushed the update-api branch 2 times, most recently from 531d09e to 670804c Compare April 25, 2023 14:19
Mikalai Radchuk added 2 commits April 25, 2023 15:24
Updates dependencies
9582ed8 
Signed-off-by: Mikalai Radchuk <[email protected]>
Updates generated files
db8daa0 
Signed-off-by: Mikalai Radchuk <[email protected]>
@m1kola m1kola marked this pull request as ready for review April 25, 2023 14:50
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2023
@openshift-ci openshift-ci bot requested review from ankitathomas and benluddy April 25, 2023 14:50
@m1kola m1kola mentioned this pull request Apr 25, 2023
Merged
11 tasks
@grokspawn
Copy link
Contributor

grokspawn commented Apr 26, 2023

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2023
tmshort
tmshort approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd like to see another review (with the /lgtm)

@openshift-ci
Copy link

openshift-ci bot commented Apr 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, m1kola, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@perdasilva
Copy link
Collaborator

perdasilva commented Apr 26, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2023
@openshift-merge-robot openshift-merge-robot merged commit cf13b77 into operator-framework:master Apr 26, 2023
@m1kola m1kola deleted the update-api branch April 26, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmshort tmshort tmshort approved these changes

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@benluddy benluddy Awaiting requested review from benluddy

Assignees

@perdasilva perdasilva

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@m1kola @grokspawn @perdasilva @tmshort @openshift-merge-robot