Switches from BundleLookupFailed defined in OLM to the one defined in the .../api package#2959
Merged
perdasilva merged 1 commit intooperator-framework:masterfrom May 22, 2023
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
11 tasks
m1kola
force-pushed
the
BundleLookupFailed-todo-cleanup
branch
from
c48e609 to
86aa8e4
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
perdasilva
approved these changes
May 22, 2023
Collaborator
perdasilva
left a comment
perdasilva
left a comment
There was a problem hiding this comment.
lgtm - nice! thanks for not letting this drop!!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankitathomas, m1kola, perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Signed-off-by: Mikalai Radchuk <[email protected]>
perdasilva
force-pushed
the
BundleLookupFailed-todo-cleanup
branch
from
86aa8e4 to
8ca28d8
Compare
|
New changes are detected. LGTM label has been removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
BundleLookupFailedis currently defined in the OLM codebase, but the latest release of thegithub.com/operator-framework/apipackage containsBundleLookupFaileddefinition (see the relevant PR).This PR updates OLM to switch to the constant defined in
github.com/operator-framework/apiMotivation for the change:
Cleanup of the old TODO.
Architectural changes:
Refactoring
Testing remarks:
Existing tests should cover changes.
Reviewer Checklist
/doc[FLAKE]are truly flaky and have an issue