bump envtest, golangci-lint, and kind#6088
Merged
everettraven merged 2 commits intooperator-framework:masterfrom Oct 17, 2022
Merged
bump envtest, golangci-lint, and kind#6088everettraven merged 2 commits intooperator-framework:masterfrom
everettraven merged 2 commits intooperator-framework:masterfrom
Conversation
Signed-off-by: Bryce Palmer <[email protected]>
Contributor
Author
|
/hold I need to add a changelog for the ansible changes. |
openshift-ci
bot
added
the
do-not-merge/hold
Signed-off-by: Bryce Palmer <[email protected]>
Contributor
Author
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
grokspawn
approved these changes
Oct 17, 2022
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
K8S_VERSIONto be1.25.0which bumps k8s version used by envtest to be 1.25.0golangci-lintto be1.50.0which is the latest and works with Go 1.19kindto0.16.0which is the latest and defaults to using k8s 1.25.2 as the node imageReadHeaderTimeouttohttp.Servercreation logic for ansible.make lintlocally without this lead to linting errors stating that without theReadHeaderTimeoutthere is the potential for a Slowloris attack.Motivation for the change:
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs