refctor: Migrate handler to use config#49
Merged
Brayden merged 1 commit intoouterbase:mainfrom Dec 16, 2024
Merged
Conversation
Member
|
I have it on my EOY list to add unit tests to make sure changes don't break other features so until I get those in I'll run this PR through my list I have and report back. Can't see how anything would go wrong with this though and it looks good. I take it this PR is in a good spot to merge in if all tests pass? |
Collaborator
Author
|
Yep should be, it just swaps out env variables for config so should be pretty much good to go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR removes the dependancy of the cloudflare environment from the handler and inner logic. The idea is that by doing this, we can then enable more granular configurability of StarbaseDB (e.g. disabling routes) and also package it up as a module to allow users to use it in existing setups.